Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable optional tablib dependencies #1647

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Oct 2, 2023

Problem

Closes #1459

Allows for lighter packages as doesn't install all tablib dependencies by default.

Solution

Used optional dependencies.

Acceptance Criteria

This is a breaking change, so I have documented in v4 release notes.

@matthewhegarty matthewhegarty marked this pull request as ready for review October 10, 2023 10:23
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Seems like a good idea.

@matthewhegarty matthewhegarty merged commit 08655a5 into django-import-export:release-4 Oct 10, 2023
11 checks passed
@matthewhegarty matthewhegarty deleted the issue-1459-optional-dependencies branch October 10, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants