Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize widget render() #1657

Merged
merged 27 commits into from Oct 24, 2023
Merged

Standardize widget render() #1657

merged 27 commits into from Oct 24, 2023

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Oct 18, 2023 •
edited

Problem

  • Inconsistent values returned from Widget render().

Closes #1324 #1495 #1631 #1635 #1649

Solution

  • Standardised methods and added documentation
  • Deprecated obj param - not used, and I cannot see a use case where you need the instance in render().
    • I have deprecated rather than removed in case a use case becomes apparent.

Acceptance Criteria

  • Unit tests
  • Manual testing

@matthewhegarty matthewhegarty changed the base branch from main to release-4 October 18, 2023 11:00
@matthewhegarty matthewhegarty mentioned this pull request Oct 23, 2023
Closed
@matthewhegarty matthewhegarty marked this pull request as ready for review October 24, 2023 13:04
@matthewhegarty matthewhegarty mentioned this pull request Oct 24, 2023
Closed
pokken-magic
pokken-magic approved these changes Oct 24, 2023
View reviewed changes
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this all makes sense to me I think, it's a lot but tests passing and stuff :) Nice work.

tests/core/tests/test_permissions.py Show resolved Hide resolved
tests/core/tests/test_widgets.py Outdated Show resolved Hide resolved
@matthewhegarty matthewhegarty merged commit 3f41d37 into django-import-export:release-4 Oct 24, 2023
11 checks passed
@matthewhegarty matthewhegarty deleted the issue-1649-widget-string-handling branch October 24, 2023 20:11
@matthewhegarty matthewhegarty mentioned this pull request Oct 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokken-magic pokken-magic pokken-magic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

yaml export crashes for objects with decimal values
2 participants
@matthewhegarty @pokken-magic