Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable defining the model in the Resource meta via string #1669

Conversation

EricOuma
Copy link
Member

Problem

Resolves #1581

Solution

Check if the model in the resource meta is a string and get the model class from it

Acceptance Criteria

Have you written tests? Have you included screenshots of your changes if applicable? Yes

Did you document your changes? Yes

@matthewhegarty
Copy link
Contributor

Looks good - thanks for adding this. We have a pre-commit failure. Please could you install pre-commit, and then reformat, and push again.

thanks

@matthewhegarty
Copy link
Contributor

It looks like this is failing on another branch as well - I'll take a look as to why.

@EricOuma
Copy link
Member Author

EricOuma commented Oct 29, 2023 via email

@matthewhegarty
Copy link
Contributor

don't know why the linter suddenly started giving errors. I'll fix it in release-4, then you can merge

@EricOuma
Copy link
Member Author

EricOuma commented Oct 29, 2023 via email

@matthewhegarty
Copy link
Contributor

It's passing on release-4 - no idea why - you could merge and push again?

import_export/resources.py Outdated Show resolved Hide resolved
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @EricOuma
I made some minor adjustments for formatting.

@matthewhegarty matthewhegarty merged commit 7186ec9 into django-import-export:release-4 Nov 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants