New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enable defining the model in the Resource meta via string #1669
enable defining the model in the Resource meta via string #1669
Conversation
Looks good - thanks for adding this. We have a pre-commit failure. Please could you install pre-commit, and then reformat, and push again. thanks |
It looks like this is failing on another branch as well - I'll take a look as to why. |
[image: image.png]
the linter is complaining that there should be spaces after the comma. The
failures are from existing code in the release-4 branch
…On Sun, 29 Oct 2023 at 13:29, Matt Hegarty ***@***.***> wrote:
It looks like this is failing on another branch as well - I'll take a look
as to why.
—
Reply to this email directly, view it on GitHub
<#1669 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4HSZAKEJFEOHHM7NVJ2U3YBYOYTAVCNFSM6AAAAAA6UXPEK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGA2TSNZTGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
--
*Work hard and smart Anywhere with the resources you have.*
|
don't know why the linter suddenly started giving errors. I'll fix it in release-4, then you can merge |
Ok, thanks.
…On Sun, 29 Oct 2023 at 13:40, Matt Hegarty ***@***.***> wrote:
don't know why the linter suddenly started giving errors. I'll fix it in
release-4, then you can merge
—
Reply to this email directly, view it on GitHub
<#1669 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4HSZER6REQ4BZJVETUZCLYBYQBBAVCNFSM6AAAAAA6UXPEK6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGA3DCOJYGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
--
*Work hard and smart Anywhere with the resources you have.*
|
It's passing on release-4 - no idea why - you could merge and push again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @EricOuma
I made some minor adjustments for formatting.
7186ec9
into
django-import-export:release-4
Problem
Resolves #1581
Solution
Check if the model in the resource meta is a string and get the model class from it
Acceptance Criteria
Have you written tests? Have you included screenshots of your changes if applicable? Yes
Did you document your changes? Yes