Support additional export parameters when exporting from Admin UI action #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thewhegarty/django-import-export into issue-1440-export-multiple-resources
This was
linked to
issues
Nov 8, 2023
pokken-magic
approved these changes
Nov 14, 2023
matthewhegarty
merged commit b210310
into
django-import-export:release-4
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1440
The issue is that full export workflow (selecting resource and file format) is not presented when exporting via actions. This adds the export workflow (which can be disabled if required).
The change is summarised here
Solution
If exporting from an action, selected item primary keys are read. The export action then renders the standard 'export' page, with chosen resources as a hidden field.
This removes the need for the 'file format' and 'resource' drop downs in the action UI (it doesn't really belong here anyway).
Additional changes
action_formats.js- no longer required as a result of this change.Acceptance Criteria