fix declaring existing model fields in ModelResrouce altering export … #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
requested changes
Nov 23, 2023
matthewhegarty
requested changes
Nov 24, 2023
matthewhegarty
approved these changes
Nov 24, 2023
matthewhegarty
merged commit 9f63bfc
into
django-import-export:release-4
11 checks passed
cocorocho
deleted the
fix-declared-model-fields-altering-export-order
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1663
Problem
Declaring existing model field(s) in
ModelResourcechanges export orderSolution
On
ModelDeclarativeMetaclassdefinition, if resource field exists in model fields, keep the order instead of pushing all declared fields before model fields.Acceptance Criteria
Have you written tests? Have you included screenshots of your changes if applicable?
Yes
Did you document your changes?
Yes