added support for python3.12 #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobTilton
approved these changes
Dec 7, 2023
RobTilton
approved these changes
Dec 7, 2023
matthewhegarty
added a commit
that referenced
this pull request
Dec 9, 2023
* added support for python3.12 (#1698) * added support for python3.12 * Update changelog.rst * added catch for DeprecationWarnings * added deprecation catch * handle deprecation warnings * updated changelog * added decorator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Django now officially supports python3.12
Solution
Update config to reflect that python3.12 is supported
This change includes
catch_warnings()block for the deprecation warning from openpyxl is resolved:The fix for the deprecation will have to be included in a tablib release for it to be resolved in import_export.
Acceptance Criteria
test run