Remove test dependencies observed when running tests with --reverse
#1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
requested changes
Dec 5, 2023
matthewhegarty
changed the title
--reverse
condensed, corrected reference
|
Seems I am running pre-commit 3.5, and the pre-commit.yml is using v3.0.0 not sure if that's the reason or not, but besides that I am out of ideas. |
matthewhegarty
approved these changes
Dec 7, 2023
matthewhegarty
merged commit f288161
into
django-import-export:release-4
11 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Running tests with "--reverse" flag caused Errors
Solution
Removed problem class BookWithObjectRepr
Refractored test_import_data_unchanged
Acceptance Criteria
I've documented the changes. no screen shots, or tests where needed. In my opinion