Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customizable storage #1708

Merged
merged 6 commits into from
Dec 12, 2023
Merged

Customizable storage #1708

merged 6 commits into from
Dec 12, 2023

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented Dec 11, 2023 •
edited

Problem

Closes issue #1210

Solution

Allows for configuration of a custom storage backend using existing Django config mechanisms

Acceptance Criteria

  • Have added integration tests
  • Have tested manually, including upload to s3 bucket using django-storages.

@matthewhegarty matthewhegarty changed the base branch from main to release-4 December 11, 2023 18:06
@matthewhegarty matthewhegarty mentioned this pull request Dec 12, 2023
Closed
@matthewhegarty matthewhegarty marked this pull request as ready for review December 12, 2023 15:20
@matthewhegarty matthewhegarty linked an issue Dec 12, 2023 that may be closed by this pull request
Customizeable MediaStorage #1210
Closed
pokken-magic
pokken-magic approved these changes Dec 12, 2023
View reviewed changes
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me; code comments are purely opinion and may be safely ignored if you disagree :)

import_export/tmp_storages.py Outdated Show resolved Hide resolved
import_export/tmp_storages.py Show resolved Hide resolved
docs/advanced_usage.rst Show resolved Hide resolved
@matthewhegarty matthewhegarty merged commit 2c7f456 into django-import-export:release-4 Dec 12, 2023
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1210-customizable-storage branch January 11, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokken-magic pokken-magic pokken-magic approved these changes

@RobTilton RobTilton RobTilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Customizeable MediaStorage
3 participants
@matthewhegarty @pokken-magic @RobTilton