Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relocated admin integration into unique top level rst file. #1713

Merged
merged 17 commits into from Dec 13, 2023

Conversation

RobTilton
Copy link
Contributor

Problem

Advanced_usage.rst was becoming massive.

Solution

copy paste section into a new file.

Acceptance Criteria

changelog.rst updated.

Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up. A couple of things left to do

  1. Update index.rst so that the link to 'admin integration' appears after 'advanced usage'
  2. There are still some sections which need to be copied over from advanced_usage, i.e from 'importing' onwards

Existing v4 docs are here for reference.

You can build the docs locally to check they look ok before pushing.

@RobTilton RobTilton marked this pull request as draft December 13, 2023 09:52
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great - thanks

@matthewhegarty matthewhegarty linked an issue Dec 13, 2023 that may be closed by this pull request
@matthewhegarty matthewhegarty marked this pull request as ready for review December 13, 2023 16:59
@matthewhegarty matthewhegarty merged commit 3fa68e2 into django-import-export:release-4 Dec 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor docs to move 'Admin integration' section to top level
2 participants