Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect color scheme override #1728

Conversation

ZibingZhang
Copy link
Contributor

Fixes cases not covered by #1720.

Problem

image We can see that the background color is overridden by the rule below despite the fact that the chosen color theme is `light`.
@media (prefers-color-scheme: dark) {
  table.import-preview td del {
    background-color: #001919 !important;
  }
}

Solution

How did you solve the problem?

image

I add the rule below to override this CSS rule which we can see fixes the issue.

html[data-theme="light"] table.import-preview td del {
  background-color: #ffe6e6 !important;
}

Acceptance Criteria

Have you written tests? Have you included screenshots of your changes if applicable?
Did you document your changes?

@coveralls
Copy link

coveralls commented Dec 27, 2023

Coverage Status

coverage: 100.0%. remained the same
when pulling c7de9a0 on ZibingZhang:zizhang-respect-color-scheme-patch
into 1be341e on django-import-export:main.

Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - would you mind adding to changelog:

Fix issue with highlight when using 'light' color scheme (#1728)

@matthewhegarty matthewhegarty merged commit c46cf33 into django-import-export:main Dec 29, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants