New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored test_resources.py into test_modelresources package #1733
Refactored test_resources.py into test_modelresources package #1733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. It is much better to have smaller modules like you have added. I have made a couple of comments which I think would improve the PR.
tests/core/tests/test_resources/test_modelresource/test_data_deletion_dry_run.py
Outdated
Show resolved
Hide resolved
tests/core/tests/test_resources/test_modelresource/test_data_deletion_dry_run.py
Outdated
Show resolved
Hide resolved
I have removed the |
I have merged recent changes from release-4 and pushed to this branch (in order to resolve conflicts). You'll need to pull the branch if you want the recent changes. |
Sure, thank you for resolving the conflicts |
I merged recent changes from |
I'm happy to merge this as it is. I would like to do so soon because it is blocking other work. I will hold off if you want to make more changes. Please can you let me know. |
Hi @matthewhegarty , I was trying to figure out what do i need to take care of, i am confused. Can you help me with it |
Hi - it's all good - I will merge. Thanks for all your help. |
35d5272
into
django-import-export:release-4
Problem
What problem have you solved?
The
test_resources.py
module exceeded 1.8k lines, becoming difficult to navigate and manage over time as more resource tests were added.Solution
How did you solve the problem?
Added
test_modelresources
packageSplit
ModelResource
tests into multiple classes.Acceptance Criteria
Have you written tests? Have you included screenshots of your changes if applicable?
Did you document your changes?
Tests executed against test_resources package to confirm no change in overall coverage or results.
No UI or documentation changes were required for this strictly organizational refactor.