-
-
Notifications
You must be signed in to change notification settings - Fork 786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix indentation for skip_row docstring #1743
Fix indentation for skip_row docstring #1743
Conversation
Thanks for submitting. Feel free to add your name to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment re line length
c3eb9ba
to
aaaa569
Compare
@matthewhegarty Thanks for the quick response. I think I applied the changes for the check. I also found some more indentation issues that intersphinx wasn't happy about. If you run your setup on |
I already saw the failed test. Will look into it :) |
Thanks. I couldn't run with |
Hi - any chance you could look into this so I can get the fix into the next release. |
Sorry for keep you waiting. I found one more issue with the internal linking that I wasn't really able to solve for now (very strange rabbit hole). I'll see if I can find something for it, but I should have something by the middle of next week at the latest. Sorry again for the delay. |
np - thanks for taking this on, much appreciated. |
Without the newline before the code block intersphinx isn't able to parse the docstring. I also adjusted the indentation of the block and propose to use the python environment for the code block.
aaaa569
to
3f64109
Compare
Thank you - will merge |
Without the newline before the code block intersphinx isn't able to parse the docstring. I also adjusted the indentation of the block and propose to use the python environment for the code block.
Problem
Intersphinx isn't able to parse the docstring for
skip_row
which is results in failing documentation builds.Related issue: #1742
Solution
I added a newline before the code block and optionally adjusted the indentation and code environment of the block.