Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with model passed to Resource constructor crashes on export #1745

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1716

Solution

Passing the model class to the constructor is redundant.

Acceptance Criteria

  • Added a test which proves the crash occurs if the fix is not in place.

@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 1ecdfd4 on matthewhegarty:issue-1716-export-crash
into eabba74 on django-import-export:main.

@matthewhegarty matthewhegarty merged commit 5e76e6c into django-import-export:main Jan 23, 2024
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1716-export-crash branch January 23, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when trying to open export windows with import_export 3.3.4
3 participants