Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to cover collect_failed_rows for validation errors #1753

Merged
merged 2 commits into from Feb 5, 2024
Merged

Add test to cover collect_failed_rows for validation errors #1753

merged 2 commits into from Feb 5, 2024

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1752

Increase test coverage

Solution

Added a test to cover missing line.

@matthewhegarty matthewhegarty mentioned this pull request Feb 3, 2024
Closed
@matthewhegarty matthewhegarty changed the base branch from main to release-4 February 3, 2024 15:06
@matthewhegarty
Copy link
Contributor Author

image

@matthewhegarty matthewhegarty merged commit b8b98ca into django-import-export:release-4 Feb 5, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvedang bvedang bvedang approved these changes

@RobTilton RobTilton RobTilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test needed to cover collect_failed_row option
3 participants
@matthewhegarty @bvedang @RobTilton