Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SimpleArrayWidget render crash #1771

Merged
merged 4 commits into from Mar 15, 2024
Merged

Fix SimpleArrayWidget render crash #1771

merged 4 commits into from Mar 15, 2024

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1769

Solution

Add check for None values and return value according to coerce_to_string param.

Acceptance Criteria

  • Added unit tests

@matthewhegarty matthewhegarty changed the title Issue 1769 simple array widget render Fix SimpleArrayWidget render crash Mar 12, 2024
@matthewhegarty matthewhegarty linked an issue Mar 15, 2024 that may be closed by this pull request
SimpleArrayWidget.render() crashes if value is None #1769
Closed
pokken-magic
pokken-magic approved these changes Mar 15, 2024
View reviewed changes
Copy link

@pokken-magic pokken-magic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@matthewhegarty matthewhegarty merged commit 36dc278 into django-import-export:release-4 Mar 15, 2024
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1769-SimpleArrayWidget-render branch March 15, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pokken-magic pokken-magic pokken-magic approved these changes

@RobTilton RobTilton Awaiting requested review from RobTilton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SimpleArrayWidget.render() crashes if value is None
2 participants
@matthewhegarty @pokken-magic