Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded format method overrides #1785

Merged
merged 2 commits into from Apr 4, 2024
Merged

Remove unneeded format method overrides #1785

merged 2 commits into from Apr 4, 2024

Conversation

Viicos
Copy link

@Viicos Viicos commented Apr 4, 2024

It used to be overridden for Python 2 compat

@Viicos Viicos changed the title Remove unneeded TSV.create_dataset override Remove unneeded format method overrides Apr 4, 2024
matthewhegarty
matthewhegarty requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I would prefer this goes into the release-4 branch for the forthcoming v4 release.

Please could you change the base branch to release-4?

@Viicos Viicos changed the base branch from main to release-4 April 4, 2024 19:11
@matthewhegarty matthewhegarty merged commit 0bc7a70 into django-import-export:release-4 Apr 4, 2024
7 checks passed
@matthewhegarty
Copy link
Contributor

Thanks 👍

@Viicos Viicos deleted the patch-1 branch April 4, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhegarty matthewhegarty matthewhegarty requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Viicos @matthewhegarty