Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix for crash when CharField subclass is present #1805

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1804

Solution

  • Added code to search base classes for Field to identify if there is a valid widget mapping.

Acceptance Criteria

  • added tests

@coveralls
Copy link

coveralls commented Apr 30, 2024

Coverage Status

coverage: 99.855%. remained the same
when pulling 0060a4a on matthewhegarty:issue-1804-crash-on-CharField-subclass
into 4a58cb6 on django-import-export:main.

@matthewhegarty matthewhegarty merged commit 6eb2d21 into django-import-export:main May 8, 2024
6 checks passed
@matthewhegarty matthewhegarty deleted the issue-1804-crash-on-CharField-subclass branch May 8, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0 compatiblity with AutoSlugField - unexpected keyword argument 'allow_blank'
2 participants