Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: allow import when import_id_fields is 'id' #1813

Merged
merged 6 commits into from
May 8, 2024
Merged

Fix regression: allow import when import_id_fields is 'id' #1813

merged 6 commits into from
May 8, 2024

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1812

Solution

Re-added checks from v3 which permit imports when 'id' field is not specified.

Acceptance Criteria

  • Added test

@matthewhegarty matthewhegarty mentioned this pull request May 3, 2024
Closed
@coveralls
Copy link

coveralls commented May 3, 2024 •
edited

Coverage Status

coverage: 99.855% (+0.001%) from 99.854%
when pulling e4108cf on matthewhegarty:issue-1812-import-non-pk-rows
into 9839a28 on django-import-export:main.

@matthewhegarty matthewhegarty mentioned this pull request May 8, 2024
Closed
@BabuDip
Copy link

BabuDip commented May 8, 2024

This does not work for this issue

@matthewhegarty matthewhegarty merged commit bc1228e into django-import-export:main May 8, 2024
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1812-import-non-pk-rows branch May 8, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't import file without an id column in V4
3 participants
@matthewhegarty @coveralls @BabuDip