Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle crash when importing custom column name #1822

Merged
merged 7 commits into from
May 13, 2024
Merged

Handle crash when importing custom column name #1822

merged 7 commits into from
May 13, 2024

Conversation

matthewhegarty
Copy link
Contributor

@matthewhegarty matthewhegarty commented May 11, 2024 •
edited

Problem

Closes #1815

Solution

Added additional checking for either attribute name or column name

Acceptance Criteria

Added tests and documentation.

@coveralls
Copy link

coveralls commented May 11, 2024 •
edited

Coverage Status

coverage: 99.856% (+0.001%) from 99.855%
when pulling da7b4c4 on matthewhegarty:issue-1815-import-with-custom-column-name
into bdc35eb on django-import-export:main.

@matthewhegarty matthewhegarty merged commit 33f1807 into django-import-export:main May 13, 2024
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1815-import-with-custom-column-name branch May 13, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Referencing a column alias in the fields list causes a crash on import
2 participants
@matthewhegarty @coveralls