Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with widget assignment for custom ForeignKey subclasses #1826

Conversation

matthewhegarty
Copy link
Contributor

Problem

Closes #1817

If a project contains a custom FK field implementation, then this can crash on startup.

Solution

Added a missing code block to call the get_fk_widget() method.

Acceptance Criteria

  • Added test

@coveralls
Copy link

coveralls commented May 13, 2024

Coverage Status

coverage: 99.952%. remained the same
when pulling 4419a99 on matthewhegarty:issue-1817-ChainedForeignKey
into c69e32d on django-import-export:main.

@matthewhegarty matthewhegarty merged commit 2f108b6 into django-import-export:main May 13, 2024
13 checks passed
@matthewhegarty matthewhegarty deleted the issue-1817-ChainedForeignKey branch May 13, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: Widget.__init__() got an unexpected keyword argument 'key_is_id' when upgrading from 3.8 to 4.0
2 participants