refactored DateWidget & DateTimeWidget & TimeWidget #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewhegarty
requested changes
May 16, 2024
There was a problem hiding this comment.
Thanks for submitting.
- I had some test failures when running this, please can you look into it.
- Please can you run pre-commit to format your code.
- Feel free to add your name to AUTHORS
- Make BaseDateTimeWidget class abstract to enforce its use as a base class and prevent direct instantiation. - Run pre-commit hooks to ensure code formatting aligns with project standards. - Add name to AUTHORS list as a new contributor to the project.
matthewhegarty
requested changes
May 16, 2024
|
I pushed a change to |
|
I also refactored to use mixin instead of abstract base class. I think this is cleaner because the date parsing logic is now isolated to the widgets module, and the abstract declaration had no effect (it was still possible to instantiate the base class). We don't want the |
|
Thanks for all your help with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Closes #1835
The existing date handling widget classes (DateWidget, DateTimeWidget, and TimeWidget) had redundant code for format initialization and parsing, making the codebase hard to maintain.
Solution
I introduced a BaseDateTimeWidget class to centralize common format handling and parsing logic. DateWidget, DateTimeWidget, and TimeWidget now inherit from this base class, reducing redundancy and streamlining operations.