-
-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix primary key import issue, add test #1853
Fix primary key import issue, add test #1853
Conversation
…harvey/django-import-export into issue-1852-related-primary-key-import
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for raising this and crafting a fix, much appreciated 👍
I have refactored to use classes from the example application, I hope that's ok with you.
Feel free to add your name to AUTHORS if you wish.
Thanks! Yes much better test, I figured I was barking up the wrong tree. I added myself to AUTHORS and appreciate your responsiveness! One little thing... it looks like a test for #1846 (test_declared_field_export_order()) made its way into this PR. Not that it bothers me, but I wondered if that was intentional? |
I will merge soon once tests complete. Thanks for all your input on this PR.
I think that is because I merged the new test in a separate PR. If you pull and merge from upstream it should fix it. The test isn't showing in this PR's changes so it should be ok. |
@matthewhegarty I think there is typo in the code. The commit description states |
Problem
Closes #1852
Solution
Replaced
id
reference withpk
Acceptance Criteria
I wrote a test, probably very poorly so please update or advise on changes. The test failed before the widget.py change and passed afterwards.
After the fix was in place, using the test app and following the steps in the ticket, I got past the error: