Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display checkbox before label in export form #1884

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Display checkbox before label in export form #1884

merged 3 commits into from
Jun 21, 2024

Conversation

RenDelaCruz
Copy link
Contributor

Problem

Closes #1873

Solution

Export form has checkboxes before labels for alignment

Acceptance Criteria

  • Manually tested
  • Updated screenshot of export form

@RenDelaCruz RenDelaCruz force-pushed the feat/put-boolean-field-before-label branch from 2edd3e8 to 510b4c1 Compare June 20, 2024 02:37
matthewhegarty
matthewhegarty approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for submitting this. I had a couple of questions about the implementation.

import_export/forms.py Show resolved Hide resolved
import_export/templates/admin/import_export/export.html Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

coverage: 100.0%. remained the same
when pulling 510b4c1 on RenDelaCruz:feat/put-boolean-field-before-label
into 7de0ad3 on django-import-export:main.

matthewhegarty
matthewhegarty approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@matthewhegarty matthewhegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good thanks

@matthewhegarty
Copy link
Contributor

I'll hold off merging for now, with the aim for this to go into a 4.1 release.

@RenDelaCruz
Copy link
Contributor Author

Sounds good. Thank you!

@matthewhegarty matthewhegarty merged commit ba04d5c into django-import-export:main Jun 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewhegarty matthewhegarty matthewhegarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display checkbox before field label in export form for alignment
3 participants
@RenDelaCruz @coveralls @matthewhegarty