Checking for "not value" replaces all the 0's in a numeric import with the default value #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h the default value.
|
thanks for contribution @aidanlister. This fix could bring some backward compatibility for some users, so I would like to have tests for this and as well to be sure not to broke again in the future. |
|
A better fix would be to use a special value of |
|
@domenkozar what is special value of object()? |
bmihelac
added a commit
that referenced
this pull request
Dec 18, 2015
|
Something like Class NoValue(object): On Sat, 19 Dec 2015 at 1:48 AM, Bojan Mihelac notifications@github.com
|
bmihelac
added a commit
that referenced
this pull request
Apr 6, 2016
bmihelac
added a commit
that referenced
this pull request
Apr 6, 2016
|
this should be fixed in e16b7a7. Please reopen if needed |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.