Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide default value in diff when importing a new instance #458

Conversation

thauk-copperleaf
Copy link
Contributor

When importing a new instance that has a field with a default value, the preview diff shows a red deletion for the default value:

new-instance-showing-default-value

Since the instance is new, the diff should instead just highlight the new value, since nothing is being deleted. For rows that don't change the default value, continue to show the value without any highlighting:

new-instance-hiding-default-value

@bmihelac bmihelac merged commit 48027e6 into django-import-export:master May 23, 2016
@bmihelac
Copy link
Member

Thanks!!

@thauk-copperleaf thauk-copperleaf deleted the hide-new-instance-default-value-in-diff branch May 24, 2016 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants