Add diff class to generate diff HTML (and fix build) #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kept the Is this good enough for now, or should I also try to eliminate the |
…ace with zip; fix failing test
|
I noticed the build was failing after your last merge for 3.x builds: https://travis-ci.org/django-import-export/django-import-export/builds/138169098 So I've fixed one of the dependency issues here since I was refactoring the function that caused it. |
|
Yes, that seems to have fixed the build :) https://travis-ci.org/django-import-export/django-import-export/builds/138219309 |
thauk-copperleaf
changed the title
|
Yes, this fix work for python3. Thank you very much. |
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #470