Fix #375: add row to widget.clean(), obj to widget.render() #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a method `get_queryset()` to `ForeignKeyWidget` and make `fields.Field` pass `row` as an additional parameter to `widget.clean()`. This makes it possible to use `ForeignKeyWidget` with multi-column identifiers.
|
Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I accidentally force-pushed/deleted the original pull request branch and as I don't have the means to reopen the previous pull request I'm opening a new one. Please excuse this.
This pull request adds a
get_queryset()method toForeignKeyWidgetand makesfields.Fieldpass row data on to the widgets so that the queryset can be narrowed down in caseForeignKeyWidget.fieldis not unique on its own.The
objis exposed towidget.export()as a kwarg as well.This pull request is related to the following issues: #375 #188 #378
All tests pass on current master branch.