Use optimized xlsx reader #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was wondering why it takes so long to import 4000 rows long xlsx file with only two columns, made some measurements and it turned out it takes around 150 second only to populate dataset. Found out there's optimized way for read-only mode in
openpyxl.So here's a little enhancement to make use of it. On my machine it reduced read time to 0.5 seconds for the same file so I thought it might be useful to others.
Unit test for it is already there, let me know if you want some performance reports or something (tbh I'm not sure how to "officially" prove performance boost 馃樁 ).