Make deep copy of fileds from class attr to instance attr #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The fields resource class attribute is the *class-wide* definition of fields. Because a particular *instance* of the class might want to alter self.fields, we create self.fields here by copying cls.fields. Instances should always modify self.fields; they should not modify cls.fields.
|
Thanks for the contribution! Could you add a test for this behaviour? |
|
Ok, I'll do it a little bit later |
Test checks that resource instance *fields* attr doesn't refer to attr *fields* of resource class
|
I've added some tests which cover this functional |
|
Thanks @Andrew-bro for PR, @shaggyfrog for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fields resource class attribute is the class-wide definition of
fields. Because a particular instance of the class might want to
alter self.fields, we create self.fields here by copying cls.fields.
Instances should always modify self.fields; they should not modify
cls.fields.