Add support for the Django DurationField with DurationWidget. #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged, thanks a lot! |
|
You're very welcome. Thank you @bmihelac for |
|
@bmihelac Should my PR have included an update to https://github.com/django-import-export/django-import-export/blob/master/docs/changelog.rst as well? Also, do you have a plan for when you might do another release (I assume |
@shaggyfrog has made huge job on django-import-export in last months :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Django 1.8 added the DurationField which allows storing of a time duration (a Python timedelta).
Since there's no standard built-in parsing of
timedelta, I'm tying this to Django'sDurationFieldand using the parse_duration helper. This means it won't be supported on Django < 1.8, but this change handles that by ignoring them.Also adding
/django-import-export/to gitignore because the tests create files there.