Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling Field.clean() unnecessarily twice #636

Merged
merged 1 commit into from
Nov 24, 2017
Merged

Avoid calling Field.clean() unnecessarily twice #636

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions import_export/fields.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,9 @@ def save(self, obj, data):
attrs = self.attribute.split('__')
for attr in attrs[:-1]:
obj = getattr(obj, attr, None)
if self.clean(data) != None or self.saves_null_values:
setattr(obj, attrs[-1], self.clean(data))
cleaned = self.clean(data)
if cleaned is not None or self.saves_null_values:
setattr(obj, attrs[-1], cleaned)

def export(self, obj):
"""
Expand Down