Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.0.0 #687

Closed
1 task done
mgrdcm opened this issue Nov 27, 2017 · 13 comments
Closed
1 task done

Release 1.0.0 #687

mgrdcm opened this issue Nov 27, 2017 · 13 comments
Labels
stale Stale bot

Comments

@mgrdcm
Copy link
Contributor

mgrdcm commented Nov 27, 2017

This'll be the adoption of Semantic Versioning and a major/breaking release. Let's use this ticket to determine which breaking changes we want to wrap into 1.0.0 and coordinate on how to release it.

Known tickets requiring a major/breaking semver release:

@mgrdcm
Copy link
Contributor Author

mgrdcm commented Nov 27, 2017

I think we should also drop support for Python 3.3 in 1.0.0, since it has reached EOL: https://docs.python.org/devguide/index.html#index-6

The Django versions we support that support Python 3.3 also support newer versions of Python that aren't EOL'd.

@bmihelac
Copy link
Member

I think we should also drop support for Python 3.3 in 1.0.0, since it has reached EOL: https://docs.python.org/devguide/index.html#index-6

agreed

@mgrdcm
Copy link
Contributor Author

mgrdcm commented Dec 4, 2017

Now that https://github.com/django-import-export/django-import-export/tree/0.6.1 has been tagged and released, should we go ahead with the plan to make 1.0.0 the next release? I just branched and created https://github.com/django-import-export/django-import-export/tree/0.6.x we can use if there are any big bug fixes we need to do before 1.0.0 is released. So I think we can go ahead with #685 and such, how does that sound @bmihelac?

@bmihelac
Copy link
Member

bmihelac commented Dec 4, 2017

I would really like to merge this before moving forward:

77323e7

This patch looks fine by me, but would extra eyes :)

@mgrdcm
Copy link
Contributor Author

mgrdcm commented Dec 4, 2017

Ahh, OK! I just removed the 0.6.x branch, and we can redo that after #690 gets merged in and 0.6.2 gets released.

@manelclos
Copy link
Contributor

Hi! What about moving all settings to dictionary?

IMPORT_EXPORT_SETTINGS = {
    IMPORT_EXPORT_USE_TRANSACTIONS: True
    ...
}

Best doing this before 1.0.0 :)

@bmihelac
Copy link
Member

@manelclos we have only 3 settings right (https://django-import-export.readthedocs.io/en/latest/installation.html#settings)? Personally I would prefer not to complicate about that....

@manelclos
Copy link
Contributor

Ok, it was just a suggestion, as some people in PRs want to add options here and there. It would also mean maintaining both for some time...

@bmihelac
Copy link
Member

bmihelac commented Feb 6, 2018

Hey all! Is there anything that should be done before 1.0.0 release?

@manelclos
Copy link
Contributor

I use this project on several production systems. It is actively maintained. Supports latest Django versions. Has a good test coverage. Time to have a 1.0 release :)

@manelclos
Copy link
Contributor

What are the priorities from now on?

@bmihelac
Copy link
Member

There are lot of pull requests that could be incorporated (I think) and I waited until 1.0 release.

Currently I use zest.releaser to release new versions - it work great, but I would like to autmate updating changelog. Creating release description if possible would be awesome. Something like this.

Also what are best practices to allow team to upload new releases to pypi?

@stale
Copy link

stale bot commented Feb 11, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Stale bot label Feb 11, 2019
@stale stale bot closed this as completed Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Stale bot
Projects
None yet
Development

No branches or pull requests

3 participants