Refactor transaction handling #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmihelac Could you fast-forward this (it's still showing diffs in the CHANGELOG file for instance) please? Also, I see that this is assigned to "django-import-export/maintainers" for code review, but it appears you're the only person in that group? ;) |
Add `atomic_if_using_transaction` context manager and use it instead of if/else statements. Wrap `before_import`, `import_row`, `after_import` calls into `atomic_if_using_transaction`. Add tests. Refs: django-import-export#609, django-import-export#399, django-import-export#610
bmihelac
force-pushed
the
refactor-transaction-handling
branch
from
77323e7
to
dd1c085
Compare
|
@mgrdcm rebased it to master branch.sorry for misleading review request |
|
No worries! I'll try to take a look tonight, though anyone else who can should go ahead! |
|
Not sure when I'm going to be able to do a thorough review of this, might be a few days. @manelclos or @shaggyfrog can you take a look? |
|
LGTM, tests are passing (including Django 2.0 and master), plus coverage increases 0.6% Whoo-hoo! |
|
merged, thanks for review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.