Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #713: last day isn't included in results qs #714

Closed
wants to merge 1 commit into from
Closed

Fix #713: last day isn't included in results qs #714

wants to merge 1 commit into from

Conversation

pszpetkowski
Copy link

@pszpetkowski pszpetkowski commented Dec 18, 2017 •
edited

issue #713

(this probably depends on #685)

@pszpetkowski pszpetkowski mentioned this pull request Dec 18, 2017
Closed
@coveralls
Copy link

coveralls commented Dec 18, 2017 •
edited

Coverage Status

Coverage increased (+0.07%) to 91.35% when pulling c084622 on piotr-szpetkowski:master into d0157e2 on django-import-export:master.

@manelclos
Copy link
Contributor

Please see that this PR breaks support for some older django versions that we still support

@pszpetkowski
Copy link
Author

@manelclos That is true and that's why I have mentioned that it should probably wait for #685 to land first.

@bmihelac
Copy link
Member

thanks @piotr-szpetkowski, new PR is here #779 and waiting for CI results

@bmihelac bmihelac self-assigned this May 17, 2018
@bmihelac
Copy link
Member

merged in eddcacf

@bmihelac bmihelac closed this May 17, 2018
@pszpetkowski
Copy link
Author

Thanks for taking care of that - I'm glad it was useful 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmihelac bmihelac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pszpetkowski @coveralls @manelclos @bmihelac