custom js for action form also handles grappelli #719
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportActionModelAdmin
works fine with Django-Grappelli except for one little detail: on valila admin, there is a little jQuery snippet that toggles visibility of the addedfile_format
field. Because Grappelli uses different CSS classes and IDs, this toggling does not occur.This in vanila admin:
... looks like this in grapppelli:
... but in the default state looks like this:
Changes in this PR enable grappelli to benefit from the existing feature in the same way that vanila django-admin does, by hiding the second dropdown in grappelli until the "export" action is selected. Original functionality in vanila admin is not affected.
Contributing guidelines... yes I have read them. Cannot comply to most of the requirements there because they assume changes to Python code. Please let me know if I should comply to some. Happy to. Also happy if this gets merged in as is :)