Change logging level #832
Merged
Change logging level #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @aniav! Thanks for your PR and sorry for late reply. I see that travis reports some errors for this pull request. Can you check this? |
|
@bmihelac ah, sorry for that 🙈 Updated now! |
|
merged, thanks @aniav |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #527 (a long time ago) I have modified the logging level from exception to debug.
What is currently happening when using django-import-export on production is that we want to show import errors to the user and we do that in django admin, but besides from these we get loads and loads of errors being reported to Sentry, which we can't really change the configuration for without extending Resource on our end and overriding how
import_dataworks inside. Which as a result might disable the possibility to upgrade the library.I am proposing changing all
logger.exceptionstologger.debugas basically we only need these logging details when testing our code using django-import-export and in all other cases the consuming code should be able to handle the raised exceptions in the way it needs.I am happy to change the PR to whatever you find valuable, as long as the logger level is lower than error, so it doesn't get reported.