Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Django 3.2 #202

Merged
merged 4 commits into from Oct 18, 2021

Conversation

dzen
Copy link
Contributor

@dzen dzen commented Apr 7, 2021

No description provided.

@Natureshadow
Copy link
Member

Is this a change necessary for compatibility with Django 3.2?

@Natureshadow Natureshadow self-assigned this Apr 7, 2021
@dzen
Copy link
Contributor Author

dzen commented Apr 7, 2021

Two things I noted :

  • I think the attnameattribute seems to be removed, I did not find any reference for the moment
  • It seems there are some SQL improvements which breaks the sql regex in
    _ORDER_BY_LIMIT_OFFSET_RE = re.compile(
    r'(?:\bORDER BY\b\s+(.+?))?\s*(?:\bLIMIT\b\s+(-?\d+))?\s*(?:\bOFFSET\b\s+(\d+))?$')

I'm trying to fix the second point.

The commits are not very clean for the moment, I wanted to trigger a travis build.

@Natureshadow Natureshadow changed the title use get_attname() instead of attname attribute WIP: use get_attname() instead of attname attribute Apr 8, 2021
@dzen dzen force-pushed the dzen/support-django32 branch 2 times, most recently from d57865b to 88300b7 Compare April 9, 2021 09:16
@dzen
Copy link
Contributor Author

dzen commented Apr 9, 2021

Hello @Natureshadow,

I can update the commit to make it more clean.
There are failing test because of the CI, not because of the code.

@Natureshadow
Copy link
Member

Natureshadow commented Apr 10, 2021

There are failing test because of the CI, not because of the code.

This might be true for the one pipeline failing because of missing build dependencies, but not for those failing in Django 2.2.

@dzen dzen changed the title WIP: use get_attname() instead of attname attribute WIP: Add support for Django 3.2 Apr 13, 2021
@dzen
Copy link
Contributor Author

dzen commented Apr 13, 2021

hi @Natureshadow I updated the test and cleaned the commit.

Hope You'll have a few times to review it.

Thanks

@Natureshadow Natureshadow changed the title WIP: Add support for Django 3.2 Add support for Django 3.2 Apr 13, 2021
@Natureshadow
Copy link
Member

Looks good. Any objections, @rbarrois ?

@dzen
Copy link
Contributor Author

dzen commented Apr 19, 2021

any news on this ? :)

With a new release, we will include the database router improvements too.

Thanks

@Natureshadow
Copy link
Member

I will merge if @rbarrois does not object today.

@mapreri
Copy link

mapreri commented Oct 18, 2021

Any update on this merge?

@Natureshadow Natureshadow merged commit d3a0b20 into django-ldapdb:master Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants