Fix saving dictionaries.

constance/admin.py

@@ -19,7 +19,7 @@
 from django.utils.translation import ugettext_lazy as _
 from leonardo.forms import Layout, SelfHandlingForm, Tab, TabHolder
 
-from .forms import JSONTextArea
+from .forms import JSONTextArea, JsonField
 from . import LazyConfig, settings
 
 try:
@@ -45,7 +45,7 @@
 })
 
 
-DICT_LIKE = (fields.CharField, {
+DICT_LIKE = (JsonField, {
     'widget': JSONTextArea(attrs={'rows': 10, 'cols': 30}),
     'required': False,
 })
@@ -131,9 +131,9 @@ def __init__(self, initial, *args, **kwargs):
         self.initial['version'] = version_hash.hexdigest()
 
     def handle(self, request, data):
-        for name in data.keys():
+        for name in self.cleaned_data.keys():
             if not name == "version":
-                value = data.get(name, settings.CONFIG.get(name)[0])
+                value = self.cleaned_data.get(name, settings.CONFIG.get(name)[0])
                 setattr(config, name, value)
                 # set to settings module
                 setattr(django_settings, name, value)

constance/forms.py

@@ -11,3 +11,24 @@ def render(self, name, value, attrs=None):
         if not isinstance(value, six.string_types):
             value = json.dumps(value, indent=2, default={})
         return super(JSONTextArea, self).render(name, value, attrs)
+
+
+class JsonField(forms.Field):
+
+    widget = JSONTextArea
+
+    def to_python(self, value):
+        "Normalize data to a string."
+
+        # Return an empty list if no input was given.
+        if not value:
+            return {}
+
+        try:
+            cleaned = json.loads(value)
+        except Exception as e:
+            raise forms.ValidationError([
+                e
+            ])
+
+        return cleaned