Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to configure decimal places output #251

Merged
merged 1 commit into from Jan 10, 2017

Conversation

ivanchenkodmitry
Copy link
Contributor

Tests in django master branch are failed because they changed the logic of rendering Select widget.

I decided create pull request in django project to remove '\n' character in select options which is comes from template rendering.
See details here:
django/django#7769

I hope this request will be approved and then django-money tests will be passed.
Otherwise we should fix the test.

Thank you.

@ivanchenkodmitry
Copy link
Contributor Author

Hi!
Is it possible to rerun integration tests for the pull request?

@Stranger6667
Copy link
Collaborator

Hello!
Yes, I restarted it just now

@codecov-io
Copy link

codecov-io commented Jan 10, 2017

Current coverage is 93.89% (diff: 100%)

Merging #251 into master will increase coverage by <.01%

@@             master       #251   diff @@
==========================================
  Files            16         16          
  Lines           736        737     +1   
  Methods           0          0          
  Messages          0          0          
  Branches        142        142          
==========================================
+ Hits            691        692     +1   
  Misses           31         31          
  Partials         14         14          

Powered by Codecov. Last update 7202a1b...96f1b8d

@Stranger6667 Stranger6667 merged commit 9863be5 into django-money:master Jan 10, 2017
@Stranger6667
Copy link
Collaborator

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants