Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error emails are counted as "recipients emailed" not "admins emails" #52

Open
Henner opened this issue Jul 14, 2013 · 3 comments
Open

Comments

@Henner
Copy link

Henner commented Jul 14, 2013

a different mail function should be used:

see:
https://groups.google.com/forum/#!topic/google-appengine/YgqNjssh1Aw

@aburgel
Copy link
Member

aburgel commented Jul 15, 2013

There's a couple of issues with this. First is that django admins is not necessarily the same as app engine admins. Second is that django admin emails are created at a layer above the app engine email backend, so by the time it gets to the app engine code, you don't know that its meant for admins, which is caused by the first issue that the django admins may not be same as app engine admins.

You could check to see if all the emails in the message are meant for admins and then route it to the send_mail_to_admins function. I'd be happy to take a pull request if you'd like to try fixing the issue, but it might end up being too complicated for this case.

@Henner
Copy link
Author

Henner commented Jul 15, 2013

OK, I will give it a shot.
I would define an extra settings entry with a list of GAE admins:
GAE_ADMINS = []

@Henner
Copy link
Author

Henner commented Jul 17, 2013

Hmm, looking deeper into this, it does not make sense to have a GAE_ADMINS settins. I think a pseudo-email like "admins@APP-ID.appspotmail.com" in the settings of ADMINS would fit best, as send_mail_to_admins always mail to all app admins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants