Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect to unread view after mark notification as read #140

Merged
merged 2 commits into from
Aug 22, 2016

Conversation

osminogin
Copy link
Contributor

In its current form it does not make sense.

You press on the cross (the message is marked as read), but after redirected to the all notification view and still see marked message. It's very simple to fix.

@osminogin osminogin changed the title Redirect to unread view after mark as read Redirect to unread view after mark notification as read Aug 13, 2016
@coveralls
Copy link

coveralls commented Aug 14, 2016

Coverage Status

Coverage remained the same at 89.149% when pulling feeec2c on osminogin:master into dca99e9 on django-notifications:master.

@LegoStormtroopr
Copy link
Contributor

LegoStormtroopr commented Aug 14, 2016

Yeah this seems like a fair call. I like the change.

If there aren't objections in the next day or two I'll organise to pull it in. Thanks!

@zhang-z zhang-z merged commit 58786cf into django-notifications:master Aug 22, 2016
@osminogin
Copy link
Contributor Author

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants