Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for Python 3.7 and latest versions of Django. #259

Conversation

YPCrumble
Copy link
Contributor

Thanks for maintaining this repo! I noticed the docs only specify Django/Python compatibility up to Python 3.6 and Django 2.0.

Tests continue to pass up to Django 2.2/Python 3.7. Is it fair to say that these versions should be supported as well? If so here's the PR to update the build matrix :).

Please let me know if any questions or if I can adjust anything!

@coveralls
Copy link

coveralls commented Jul 22, 2019

Coverage Status

Coverage increased (+0.3%) to 93.852% when pulling 38e14b3 on YPCrumble:feature/update_tests_for_latest_django into bf772f6 on django-notifications:master.

@YPCrumble YPCrumble force-pushed the feature/update_tests_for_latest_django branch from d9eae05 to 38e14b3 Compare July 22, 2019 14:49
Copy link
Collaborator

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YPCrumble thanks for contributing!

Can you try changing dist to bionic?

@YPCrumble
Copy link
Contributor Author

Closing as this seems already done :D

@YPCrumble YPCrumble closed this Aug 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants