Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added never_cache to some views to avoid no-update bug #266

Merged
merged 1 commit into from
Dec 19, 2019

Conversation

alvarovelezgalvez
Copy link
Contributor

After update to Python 3.7.3 and Django 2.2.5 updating of live badge started to show wrong number of unread notifications.

Debugging the application we noticed that the 3 endpoints were serving cached values instead of the real ones. We fixed it adding the @never_cache decorator to those endpoints

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 91.873% when pulling e7f1a24 on alvarovelezgalvez:master into bf772f6 on django-notifications:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 91.873% when pulling e7f1a24 on alvarovelezgalvez:master into bf772f6 on django-notifications:master.

@coveralls
Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage decreased (-1.5%) to 91.976% when pulling e7f1a24 on alvarovelezgalvez:master into bf772f6 on django-notifications:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 91.873% when pulling e7f1a24 on alvarovelezgalvez:master into bf772f6 on django-notifications:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 91.873% when pulling e7f1a24 on alvarovelezgalvez:master into bf772f6 on django-notifications:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.6%) to 91.873% when pulling e7f1a24 on alvarovelezgalvez:master into bf772f6 on django-notifications:master.

@nemesifier nemesifier merged commit b63a8ea into django-notifications:master Dec 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants