Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test python 3.8 and Django 3.0 #273

Merged
merged 3 commits into from
Feb 21, 2020
Merged

Test python 3.8 and Django 3.0 #273

merged 3 commits into from
Feb 21, 2020

Conversation

giff-h
Copy link
Contributor

@giff-h giff-h commented Jan 19, 2020

Aligns the doc specs to match tested versions

We're trying to upgrade to Django 3.0 as soon as possible, so I'm going through all our dependencies and helping ensure they work on the latest version of everything.

Aligns the doc specs to match tested versions
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 93.439% when pulling 95c6a48 on hamstap85:latest-version-tests into 0fba034 on django-notifications:master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 93.439% when pulling 95c6a48 on hamstap85:latest-version-tests into 0fba034 on django-notifications:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 93.439% when pulling 95c6a48 on hamstap85:latest-version-tests into 0fba034 on django-notifications:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 93.439% when pulling 95c6a48 on hamstap85:latest-version-tests into 0fba034 on django-notifications:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.4%) to 93.439% when pulling 95c6a48 on hamstap85:latest-version-tests into 0fba034 on django-notifications:master.

@coveralls
Copy link

coveralls commented Jan 19, 2020

Coverage Status

Coverage increased (+0.3%) to 92.352% when pulling 9596b59 on hamstap85:latest-version-tests into 0fba034 on django-notifications:master.

@giff-h
Copy link
Contributor Author

giff-h commented Jan 19, 2020

tox passes locally, possibly the django 1.11 version in the travis envs needs to be latest

Copy link
Collaborator

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hamstap85 let's remove django 1.11, end of support was on December 2, 2017.

@giff-h
Copy link
Contributor Author

giff-h commented Jan 24, 2020

@nemesisdesign That was mainstream support, LTS is still active until about April https://www.djangoproject.com/download/#supported-versions unless you don't feel the need to support it LTS

Copy link
Collaborator

@nemesifier nemesifier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Offering extended support requires resources, this project is working in best-effort mode, so I think we can drop it. April is around the corner anyway.

I will release a version on pypi before merging this patch and then release another one with a higher version so in case anyone needs to use django 1.11 they can use the previous version.

@giff-h
Copy link
Contributor Author

giff-h commented Feb 5, 2020

@nemesisdesign Is there a target date for the version support shift release?

@aaronn
Copy link

aaronn commented Feb 5, 2020

Would love to see this merged soon. @nemesisdesign I saw you mentioned you didn't have pypi access before– do you have it now? Or are you doing a fork?

@tdruez
Copy link

tdruez commented Feb 11, 2020

+1 on merging this, it's a blocker for upgrading to Django 3.0

@nemesifier nemesifier merged commit ddfd1c3 into django-notifications:master Feb 21, 2020
@nemesifier
Copy link
Collaborator

Got access, let's move on!

@aaronn
Copy link

aaronn commented Feb 21, 2020

Exciting!

@giff-h giff-h deleted the latest-version-tests branch February 24, 2020 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants