Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the default serializers #5

Closed
mvantellingen opened this issue Feb 10, 2015 · 5 comments
Closed

Allow overriding the default serializers #5

mvantellingen opened this issue Feb 10, 2015 · 5 comments

Comments

@mvantellingen
Copy link

We might want to make the Serializers overridable by the project using the app. By creating abstract serializers users can implement their own just like currently possible with the oscar models/classes.

This would mean that we would use e.g. get_class('ProductSerializer') in the views

@specialunderwear
Copy link
Member

Not a bad idea.
Is that coming from personal experience?

@maerteijn
Copy link
Member

Agree! Now we are overwriting the views for using custom serializers.

@specialunderwear
Copy link
Member

I just can't really see how that would work, since this is not a core app.

@specialunderwear
Copy link
Member

Somebody had something to say about this in #33

@maerteijn
Copy link
Member

I'll close this issue for now as #33 is in basic the same question. After we released 1.0 we will think about how to override serializers in a easy way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants