Check User model actually has fields for form Meta #1275
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This probably isn't enough, as the tests don't pass locally (Travis already dies with the lint errors). It's a bit odd because the |
| fields = ('first_name', 'last_name', 'email', 'password1', 'password2') | ||
| # from Django 1.6 the User model can be overridden not to have these fields | ||
| # without the explicit check here this class def crashes the app | ||
| fields = [field for field in ['first_name', 'last_name', 'email', 'password1', 'password2'] if hasattr(User, field)] |
There was a problem hiding this comment.
This is completely incorrect in fact. User doesn't have fields as attributes.
alex-moon
pushed a commit
that referenced
this pull request
Apr 1, 2014
This is necessary because the Meta def itself is sufficient to crash the app for a different User model - the form doesn't even need to be instantiated. There is still plenty more code that makes explicit reference to first_name and last_name however. Fixes #1275 Moved to oscar.core.compat and renamed by @maikhoepfel Conflicts: oscar/apps/dashboard/partners/forms.py oscar/core/compat.py Backport of a32766b.
mbertheau
deleted the
feature/1274_user_forms_meta_fields_for_different_user_model
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because the Meta def itself is sufficient to crash the app for a different User model - the form doesn't even need to be instantiated. There is still plenty more code that makes explicit reference to first_name and last_name however.