Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification body is rendered as plain text, but passed HTML in some cases #2916

Closed
solarissmoke opened this issue Jan 15, 2019 · 2 comments
Closed

Notification body is rendered as plain text, but passed HTML in some cases #2916

solarissmoke opened this issue Jan 15, 2019 · 2 comments
Labels
☁ Bug

Comments

@solarissmoke
Copy link
Member

Issue Summary

The body for customer notifications are rendered as plain text in the detail view.

But we create notifications with HTML in the body - e.g., for stock alerts.

The resulting notifications are rendered with escaped HTML such as <a href="/catalogue/test-product_6/">test product</a> is back in stock.

We need to either allow HTML in the body, or ensure we don't provide it. We already allow HTML in the subject so it seems silly not to allow it in the body.
SmileyJames added a commit to SmileyJames/django-oscar that referenced this issue Jul 10, 2019
@SmileyJames
Fix issue django-oscar#2916. Render stock alerts as html not txt.
217a054
@SmileyJames SmileyJames mentioned this issue Jul 10, 2019
Closed
@krzysztofjeziorny
Copy link
Contributor

I can confirm this bug is still present in 3.0. Also, some strings are not translated (or translatable) in the same template.

Screenshot 2021-02-04 at 12 59 00

@specialunderwear
Copy link
Member

image this has been fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
☁ Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@specialunderwear @solarissmoke @krzysztofjeziorny