Css/less and javascript blocks are not available for checkout templates. #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emplates. The `checkout/layout.html` template should not bypass the `layout.html` template.
|
LGTM, will merge when travis is through. This doesn't need to be backported because this issue was introduced with #1569, specifically in f381d1f where I moved the JS and CSS to layout.html (so that base.html could be used for both the dashboard and the frontend without dictating JS or CSS for either) – blindly assuming all templates use layout.html and no template uses base.html directly. |
|
@itbabu, thanks for catching this :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
checkout/layout.htmltemplate should not bypass thelayout.htmltemplate.