Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addressbook > address book #1993

Merged
merged 1 commit into from
Feb 28, 2016
Merged

Conversation

cowlicks
Copy link
Contributor

@cowlicks cowlicks commented Feb 2, 2016

Closes #1984 (lol @ issue number)

I did this with:

$ grep -r --binary-files=without-match addressbook . | cut --delimiter=":" --field=1 | xargs -n1 sed -i 's/addressbook/address book/'

$ grep -r addressbook | cut --delimiter=" " -f3 | xargs -n1 sed -i 's/addressbook/address book/'

It is a two-liner because grep gives a differently formatted output for the "binary files".

I'm not sure how localization with Transifex works, so please let me know if I did something wrong here. There is no semantic change so I don't thing the translations should change.

I did this with:

$ grep -r --binary-files=without-match addressbook . | cut --delimiter=":" --field=1 | xargs -n1 sed -i 's/addressbook/address book/'

$ grep -r addressbook | cut --delimiter=" " -f3 | xargs -n1 sed -i
's/addressbook/address book/'
@codeinthehole
Copy link
Contributor

Thanks.

The transifex thing should be fine as the message files are generated from the same string in the template

codeinthehole added a commit that referenced this pull request Feb 28, 2016
addressbook > address book
@codeinthehole codeinthehole merged commit e201e93 into django-oscar:master Feb 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants