Prevent trying to save a negative quantity to a Basket #2000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basket.Line.quantity is a positive integer field, but the quantity sumation in basket.Basket.add_product made it possible to try and save negative values. This makes add_product never go below 0-quantity, thereby preventing a db exception from being thrown. Also adds a test for the described behavior.
|
👍 |
mvantellingen
added a commit
that referenced
this pull request
Feb 10, 2016
Prevent trying to save a negative quantity to a Basket
|
@mvantellingen is it intentional that a 0 quantity line can exist? I've created some funky scenarios with oscar-api by using api-basket-add-product with a -1 quantity. It kind of makes sense I could use that to go from 2 to 1. Going to 1 to 0 while keeping the line is really odd. I'm unsure if this should be addressed on django-oscar or django-oscar-api. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basket.Line.quantity is a positive integer field, but the quantity sumation in
basket.Basket.add_product made it possible to try and save negative values. This
makes add_product never go below 0-quantity, thereby preventing a db exception
from being thrown. Also adds a test for the described behavior.